feat: add new resolve web asset function#2334
Conversation
| @@ -0,0 +1 @@ | |||
| declare module '@react-native/assets-registry/registry'; | |||
There was a problem hiding this comment.
Why do we need this? Should it be also added to files that end up in release?
There was a problem hiding this comment.
Unfortunately, without it, we have a problem with typescript
There was a problem hiding this comment.
You answered only the first question here 😅
There was a problem hiding this comment.
@WoLewicki Ah, you're right sorry. Hm... I'm a little confused because I'm not sure how we build the library 🧐
There was a problem hiding this comment.
You can run npm pack to get the package that would be available on npm. Then you can add this package to a new project to test it locally. Is it what you meant?
There was a problem hiding this comment.
Does this index.d.ts file end up in the package then?
There was a problem hiding this comment.
nope, I didn't change the package.json file.
as I understand if we want to add that file we have to add them to package.json in section files, yes?
There was a problem hiding this comment.
Yes. So if it works correctly without having this index.d.ts file then why do we need it at all? Is it only needed for when developing it locally inside the library's repo?
There was a problem hiding this comment.
Maybe it would be easier to have that file in the project because it isn't included in the building process and doesn't change anything. But it's only my suggestion :D
There was a problem hiding this comment.
after a discussion about that with @jakex7 we decided to remove the index.d.ts file.
# Summary * Export `Filter` and `FeColorMatrix` components on `web` * Change filter IDs in example to be unique* * Generate filter ID when using `FilterImage`* * Hide `FilterImage` example on web, since it's crashing the whole site (see #2334) \* ID on web has to be unique, otherwise it'll use the first element with that ID, even if they are in the separate SVG elements ## Test Plan run `web-example` app ## Compatibility | OS | Implemented | | ------- | :---------: | | Web | ✅ |
2 participants
Summary
Add a new function to resolve Image asset uri.
Compatibility