feat: add web implementation SvgXml and others component#2382
Merged
Conversation
…es. Consider refactoring to remove the need for a cycle.
…rt in ReactNativeSvg
…ftware-mansion/react-native-svg into @bohdanprog/fix-problem-with-svgxml
jakex7
reviewed
Jul 31, 2024
Member
jakex7
left a comment
jakex7
left a comment
There was a problem hiding this comment.
Left some comments, please answer them
Comment on lines
42
to
46
| const uri = getUriFromSource(source); | ||
| if (isUriAnAndroidResourceIdentifier(uri)) { | ||
| if (uri && isUriAnAndroidResourceIdentifier(uri)) { | ||
| return loadAndroidRawResource(uri); | ||
| } else { | ||
| return fetchText(uri); |
Member
There was a problem hiding this comment.
If there's no URI, fetchText should be executed?
Contributor
Author
There was a problem hiding this comment.
In that case, when I updated the getUriFromSource function, it is required to add a check on line 43 to ensure that the URI exists for some reason.
Comment on lines
+82
to
+84
| if (!uri) { | ||
| return null; | ||
| } |
Member
There was a problem hiding this comment.
I believe we should check for that earlier
Contributor
Author
There was a problem hiding this comment.
I believe it's better to check the URI only in that specific place, especially if we have multiple areas where we utilize that function.
jakex7
approved these changes
Jul 31, 2024
…nto @bohdanprog/fix-problem-with-svgxml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We want to make available SvgXml and other components in the web platform.
Test Plan
We can easily check how that works by opening
Test1813.Compatibility