Skip to content

feat: placeholders for unimplemented filters and support for Web#2392

Merged
jakex7 merged 8 commits into
mainfrom
@jakex7/featAddAllFiltersOnWeb
Aug 1, 2024
Merged

feat: placeholders for unimplemented filters and support for Web#2392
jakex7 merged 8 commits into
mainfrom
@jakex7/featAddAllFiltersOnWeb

Conversation

@jakex7
Copy link
Copy Markdown
Member

@jakex7 jakex7 commented Aug 1, 2024

Summary

This PR adds placeholders for all filters to enable their use on the Web. Users can import and use them on the Web; however, on native platforms, these filters will not have any effect and will display a warning.

@jakex7 jakex7 requested a review from WoLewicki August 1, 2024 12:54
Copy link
Copy Markdown
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

Comment thread src/elements/filters/FeColorMatrix.tsx Outdated
Comment thread src/elements/filters/FeGaussianBlur.tsx Outdated
Comment thread src/lib/extract/extractFilter.ts Outdated
Comment thread src/lib/extract/types.ts
Comment thread src/xmlTags.ts Outdated
Copy link
Copy Markdown
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jakex7 jakex7 merged commit e8ed74f into main Aug 1, 2024
@jakex7 jakex7 deleted the @jakex7/featAddAllFiltersOnWeb branch August 1, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants