Resolved conflicts with upstream #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example shows how we can generate GraphQL schema on runtime. Credit to Rob Smith from Uber @ Seattle for the dynamic reloading part.
Respect Context Deadline
Add httpdynamic examples
Adding an http example for graphql-go#60 Left to do: - [ ] clean up the schema so its only in one place
Adds the simple mutation for graphql-go#60 Left to do: [ ] add an http based example
since we are using govendor
…mple examples/todo: adds update mutation
vendor: adds vendor directory
Add cli message that we are serving web app at 'http://localhost:8080/'
Signed-off-by: James Phillips <[email protected]>
Signed-off-by: James Phillips <[email protected]>
Signed-off-by: James Phillips <[email protected]>
Add support for block strings to language package
Fix utility function
SDL: Implement descriptions as strings
- benchmark lists of variable sizes - benchmark objects with a variable number of fields
Memoize field maps for Objects and Interfaces
…te-structs Hide effectively private structs
Don't format the error message unless it is really needed
Add benchmarks
README: simpler docs introduction
…' into dvic-master # Conflicts: # executor.go # Ignored: # language/ast/type_definitions.go # language/parser/parser.go # rules.go # rules_fields_on_correct_type_test.go # rules_overlapping_fields_can_be_merged.go
Author
|
Closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
However, after turning on -race, the tests show many data races, probably due to unsafe map writes/reads in Schema. Any suggestions on how you'd like to see this tackled?