Skip to content

refactor(experimental): a comparator for commitments #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

steveluscher
Copy link
Contributor

Summary

A handy utility that lets you know if one commitment is ‘lower’ than the other.

Test Plan

cd packages/rpc-core
pnpm test:unit:browser
pnpm test:unit:node

@steveluscher
Copy link
Contributor Author

steveluscher commented Oct 6, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@steveluscher steveluscher changed the base branch from 10-06-refactor_experimental_a_low-level_series_of_helpers_to_confirm_transactions to 10-05-refactor_experimental_a_function_you_can_use_to_get_a_transaction_s_signature October 6, 2023 23:52
@steveluscher steveluscher force-pushed the 10-06-refactor_experimental_a_comparator_for_commitments branch from 32d1f0a to 6d2740f Compare October 6, 2023 23:52
@steveluscher steveluscher force-pushed the 10-05-refactor_experimental_a_function_you_can_use_to_get_a_transaction_s_signature branch from 8d460e1 to b851764 Compare October 6, 2023 23:56
@steveluscher steveluscher force-pushed the 10-06-refactor_experimental_a_comparator_for_commitments branch from 6d2740f to f660f6e Compare October 6, 2023 23:56
@steveluscher
Copy link
Contributor Author

steveluscher commented Oct 7, 2023

Merge Activity

Base automatically changed from 10-05-refactor_experimental_a_function_you_can_use_to_get_a_transaction_s_signature to master October 7, 2023 07:15
@steveluscher steveluscher force-pushed the 10-06-refactor_experimental_a_comparator_for_commitments branch from f660f6e to db3d60b Compare October 7, 2023 07:15
@steveluscher steveluscher merged commit 524cb6e into master Oct 7, 2023
@steveluscher steveluscher deleted the 10-06-refactor_experimental_a_comparator_for_commitments branch October 7, 2023 07:18
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

🎉 This PR is included in version 1.87.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant