-
Notifications
You must be signed in to change notification settings - Fork 86
upgrade solana-deps to 2.2 #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
OK, CI is finally passing except for the semver check that was already failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of questions, thanks!
I'd like to actually bump everything up to v2.2.1 for the sdk crates, and v2.2.0 for the agave crates, but I can take care of that in a follow-up PR.
rust-toolchain.toml
Outdated
@@ -1,2 +1,2 @@ | |||
[toolchain] | |||
channel = "1.81.0" | |||
channel = "1.83.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we bump this to 1.84.1 to align with v2.2?
Cargo.toml
Outdated
format = "nightly-2024-12-01" | ||
lint = "nightly-2024-12-01" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these be aligned with agave and set to nightly-2024-11-22
?
Looks like there's a conflict on the lockfile -- once that's resolved, this is good to go on my side! |
cabaa4f
to
8f12d41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
#### Problem solana-program#204 did the hard work of upgrading crates to v2.2 as needed, but some of the dependencies were missed. Also, the tool suite is still on v2.1. #### Summary of changes Bump the sdk crates to v2.2.1 and the non-sdk crates to v2.2.0
#### Problem #204 did the hard work of upgrading crates to v2.2 as needed, but some of the dependencies were missed. Also, the tool suite is still on v2.1. #### Summary of changes Bump the sdk crates to v2.2.1 and the non-sdk crates to v2.2.0
No description provided.