program: Remove solana-program / sdk #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem The token-2022 program still uses solana-program and solana-sdk, which are heavy dependencies. #### Summary of changes The component crates exist to do everything needed in token-2022, so we can remove solana-program usage entirely. NOTE: since some spl-token-2022's dependencies still use solana-program, there is no huge gain just yet. That will happen when we upgrade the upstream dependencies and then upgrade token-2022 to use those. Also NOTE: this is a breaking change since we've removed the re-export of the sdk types. Considering we're now respecting semver, this shouldn't be a problem, but we did add a version of re-exports in solana-program/token#26, so maybe we should do the same thing here. Let me know!
samkim-crypto
approved these changes
Mar 5, 2025
| @@ -281,12 +281,12 @@ fn process_instruction( | |||
| async fn amount_conversions() { | |||
| let rate_authority = Keypair::new(); | |||
| let mut program_test = ProgramTest::default(); | |||
| program_test.prefer_bpf(false); | |||
There was a problem hiding this comment.
So what is the reason why the tests fail if we don't prefer bpf here?
There was a problem hiding this comment.
The prefer_bpf(false) mode of solana-program-test uses solana_program::program_stubs to implement the syscalls, which no longer works when not using solana-program. So to fix the issue, we force token-2022 to run in the VM rather than the "fake native" mode of solana-program-test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The token-2022 program still uses solana-program and solana-sdk, which are heavy dependencies.
Summary of changes
The component crates exist to do everything needed in token-2022, so we can remove solana-program usage entirely.
NOTE: since some spl-token-2022's dependencies still use solana-program, there is no huge gain just yet. That will happen when we upgrade the upstream dependencies and then upgrade token-2022 to use those.
Also NOTE: this is a breaking change since we've removed the re-export of the sdk types. Considering we're now respecting semver, this shouldn't be a problem, but we did add a version of re-exports in solana-program/token#26, so maybe we should do the same thing here. Let me know!