Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@cce
Copy link
Contributor

@cce cce commented Aug 21, 2020

When customers use our builtin http.Handler instrumentation, or call methods on ao.Trace() they get metrics aggregation for throughput, latency, and error counts aggregated by transaction name, HTTP method, and HTTP status.

This PR allows OpenTracing users to access those aggregation features by calling OT Span.SetTag() on http.url, http.method, and http.status_code. (Support for setting transaction name for use in these metrics aggregations was part of #147, but did not cover HTTP method and status.)

@cce cce requested a review from jiwen624 August 21, 2020 21:19
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2020

Codecov Report

Merging #153 into master will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   82.05%   82.19%   +0.14%     
==========================================
  Files          37       37              
  Lines        4603     4629      +26     
==========================================
+ Hits         3777     3805      +28     
+ Misses        703      700       -3     
- Partials      123      124       +1     
Impacted Files Coverage Δ
v1/ao/opentracing/tracer.go 100.00% <100.00%> (ø)
v1/ao/internal/reporter/reporter_grpc.go 70.18% <0.00%> (-0.31%) ⬇️
v1/ao/trace.go 86.25% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 875f3c2...ab4bd87. Read the comment docs.

Copy link
Contributor

@jiwen624 jiwen624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good from what I can tell 👍

@cce cce merged commit 5cf07ca into master Aug 24, 2020
@cce cce deleted the add-ot-method-status-url-aggregation branch August 24, 2020 20:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants