Fix active route CSS issue for Overview link in TOC #1210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves a styling issue where the "Overview" link in the table of contents was not highlighted when navigating to /solid-router or /solid-start. The problem stemmed from a missing trailing slash in the URL, causing the active route matching logic to fail. As a result, users could not easily identify their current section, leading to confusion during navigation.
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves a styling issue where the "Overview" link in the table of contents was not highlighted when navigating to /solid-router or /solid-start. The problem stemmed from a missing trailing slash in the URL, causing the active route matching logic to fail. As a result, users could not easily identify their current section, leading to confusion during navigation.
Description(required)
Related issues & labels