Skip to content

Fix navbar link style on sub-routes #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025

Conversation

amirhhashemi
Copy link
Collaborator

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

This PR fixes a bug where navbar links did not display the underline when on a sub-route of a project.

I also took this opportunity to refactor some code and fix the flickering issue mentioned in this PR.

Before:
image

After:
image

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Jul 3, 2025

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 2e09de5
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/6866a594713eb8000805d230
😎 Deploy Preview https://deploy-preview-1213--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@LadyBluenotes LadyBluenotes merged commit 9b45a24 into solidjs:main Jul 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants