fix: catch synchronous error #2476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Synchronous (non-promise) errors cannot be caught by
ErrorBoundary
.https://playground.solidjs.com/anonymous/98e1258d-67c8-4c53-b9cb-4bfa029d451e
Using an async function as fetcher it works:
https://playground.solidjs.com/anonymous/0e5e5348-57ef-41b3-aebf-66f8567122c8
How did you test this change?
An unit test was added to the commit.