Remove unused authentication_token column#236
Merged
Conversation
jarednorman
reviewed
Dec 5, 2022
jarednorman
left a comment
jarednorman
left a comment
Member
There was a problem hiding this comment.
My only concern here is for stores that decided to use this column for something... I would not want to drop all their "authentication tokens", whatever they put in there.
tvdeyen
reviewed
Jan 6, 2025
This column dates back to 2013, when token authentication was removed from Devise. We should not keep it. This allows new stores to start without the unused column, while old stores can still use any tokens they might be using.
mamhoff
force-pushed
the
remove-unused-columns
branch
from
156fabf to
2b2e0de
Compare
tvdeyen
approved these changes
Jan 6, 2025
jarednorman
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This column dates back to 2013, when token authentication was removed from Devise. We should not keep it.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):I have added automated tests to cover my changes.I have attached screenshots to demo visual changes.I have opened a PR to update the guides.I have updated the README to account for my changes.