Skip to content

Improve Devise config initializer #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jarednorman merged 3 commits into from
Jun 6, 2025
Merged

Improve Devise config initializer #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f7cc79
Use email regexp configured on Solidus
senemsoy Apr 30, 2025
ab21201
Fix default configuration for `Devise.secret_key`
senemsoy May 1, 2025
3eadb06
Rename Devise initializer template
senemsoy May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/generators/solidus/auth/install/install_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class InstallGenerator < Rails::Generators::Base
source_root "#{__dir__}/templates"

def generate_devise_key
template 'config/initializers/devise.rb', 'config/initializers/devise.rb', skip: true
template 'config/initializers/devise.rb.erb', 'config/initializers/devise.rb', skip: true
end

def add_migrations
Expand Down
3 changes: 0 additions & 3 deletions lib/generators/solidus/auth/install/templates/config/initializers/devise.rb
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions lib/generators/solidus/auth/install/templates/config/initializers/devise.rb.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# frozen_string_literal: true

Devise.secret_key = '<%= SecureRandom.hex(64) %>'
Devise.email_regexp = Spree::Config[:default_email_regexp]