Fix build 2025#258
Merged
Merged
Conversation
jarednorman
approved these changes
May 28, 2025
4 tasks
mamhoff
force-pushed
the
fix-build-2025
branch
3 times, most recently
from
78a5ea7 to
ced4829
Compare
We don't need this in git blame.
See solidusio/solidus#6286 for rationale
We want to test the site like a real user, not like someone constantly changing the URL bar in a browser. Let's have the specs click links.
This spec was flaky before, because it did not wait for the page to have any changes.
Useful and common to have a bin/rspec
Before accessing the cart we need to expect to be logged in.
tvdeyen
approved these changes
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates us to the latest
solidus_dev_support, and adopts thestandardrbsyntax conventions.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: