Skip to content

Address checkout spec race conditions#259

Merged
jarednorman merged 1 commit into
solidusio:mainfrom
SuperGoodSoft:senem/fix-flakey-checkout-spec
Jun 6, 2025
Merged

Address checkout spec race conditions#259
jarednorman merged 1 commit into
solidusio:mainfrom
SuperGoodSoft:senem/fix-flakey-checkout-spec

Conversation

@senemsoy

@senemsoy senemsoy commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

Summary

We want to avoid clicking the same 'Save and Continue' button three times in a row, so we've added assertions that make sure we have navigated to the next page before trying to click it again.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

We want to avoid clicking the same 'Save and Continue' button three
times in a row, so we've added assertions that make sure we have
navigated to the next page before trying to click it again.

Co-authored-by: Jared Norman <jared@super.gd>
@jarednorman jarednorman enabled auto-merge June 6, 2025 17:21
@jarednorman jarednorman requested a review from adammathys June 6, 2025 17:21
@jarednorman jarednorman disabled auto-merge June 6, 2025 17:32
@jarednorman jarednorman merged commit 5ddc1ac into solidusio:main Jun 6, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants