Use ActiveRecord::Migration instead of SolidusSupport::Migration#261
Merged
Conversation
mamhoff
force-pushed
the
remove-support-migrations
branch
from
2650e7c to
ffa8639
Compare
jarednorman
approved these changes
Aug 1, 2025
jarednorman
left a comment
jarednorman
left a comment
Member
There was a problem hiding this comment.
I assume this is safe to do because we no longer support any versions of ActiveRecord that don't have the [version] API.
`SolidusSupport::Migration[4.2]` is deprecated in favor of `ActiveRecord::Migration[4.2]`. This cleans up the test logs of many other gems, because solidus_auth_devise is used in many extension test suites.
tvdeyen
force-pushed
the
remove-support-migrations
branch
from
ffa8639 to
3c2f235
Compare
tvdeyen
approved these changes
Jan 3, 2026
tvdeyen
left a comment
tvdeyen
left a comment
Member
There was a problem hiding this comment.
Can we adjust the rails version to one we support? No one will install this gem under Rails 4.2 and who haven't installed the migrations anyway.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SolidusSupport::Migration[4.2]is deprecated in favor ofActiveRecord::Migration[4.2]. This cleans up the test logs of many other gems, because solidus_auth_devise is used in many extension test suites.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: