Cleanup test files copied over the host application#350
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #350 +/- ##
==========================================
+ Coverage 97.28% 97.31% +0.02%
==========================================
Files 189 187 -2
Lines 4526 4501 -25
==========================================
- Hits 4403 4380 -23
+ Misses 123 121 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
elia
approved these changes
Jul 6, 2023
elia
left a comment
elia
left a comment
Member
There was a problem hiding this comment.
All great ✨
I left a couple of optional comment, the one about clearing the cache deserving particular attention.
waiting-for-dev
approved these changes
Jul 7, 2023
elia
approved these changes
Jul 7, 2023
It's no more present, we can clean it up.
We don't have feature specs anymore. This change also groups multiple support helper files into a single one because they are all related to checkout.
This generic support file for specs is useless because all of its content is already included in the main spec_helper provided with the starter frontend
kennyadsl
force-pushed
the
kennyadsl/align-with-testing-guide
branch
from
f1fc2cf to
dc83686
Compare
Member
Author
|
@elia @waiting-for-dev everything addressed, waiting for the CI before merging, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There were multiple inconsistencies and outdated code. Please read commit by commit for more details.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: