Card name ignored when adding new card to an order during checkout

[milesegan]

solidus_stripe/app/models/solidus_stripe/create_intents_payment_service.rb

Line 64 in b9c0b8a

name: address_full_name,

Currently when a user checks out and adds a new card the name they entire is ignored in favor of the name on the order billing address. Seems like this line should be using the name from the card and not the address, right?

[milesegan]

This decorator seems to do the right thing here.

module CreateIntentsOrderServiceDecorator
  def payment_params
    card = response['charges']['data'][0]['payment_method_details']['card']
    address_attributes = form_data['payment_source'][stripe.id.to_s]['address_attributes']
    name = form_data['payment_source'][stripe.id.to_s]['name']

    {
      payments_attributes: [{
        payment_method_id: stripe.id,
        amount: current_order.total,
        response_code: response['id'],
        source_attributes: {
          month: card['exp_month'],
          year: card['exp_year'],
          cc_type: card['brand'],
          gateway_payment_profile_id: response['payment_method'],
          last_digits: card['last4'],
          name: name.presence || current_order.bill_address.full_name,
          address_attributes: address_attributes
        }
      }]
    }
  end

  SolidusStripe::CreateIntentsOrderService.prepend(self)
end