Bump minimum solidus_support version requirement#102
Merged
spaghetticode merged 1 commit intoFeb 12, 2021
Merged
Conversation
filippoliverani
force-pushed
the
filippoliverani/bump-solidus-support
branch
from
14014c0 to
9a9220f
Compare
SolidusSupport::combined_first_and_last_name_in_address? helper requires SolidusSupport >= 0.8 to work
filippoliverani
force-pushed
the
filippoliverani/bump-solidus-support
branch
from
9a9220f to
7ea5443
Compare
spaghetticode
approved these changes
Feb 12, 2021
spaghetticode
left a comment
spaghetticode
left a comment
Member
There was a problem hiding this comment.
@filippoliverani thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps
solidus_supportminumum required version to 0.8 becauseSolidusSupport::combined_first_and_last_name_in_address?helper is used in production code and has been implemented in that version.