Skip to content

Fix the CI after the Solidus v3.2 release#125

Merged
waiting-for-dev merged 5 commits into
solidusio:masterfrom
nebulab:elia+marc/fix-for-latest-solidus
Aug 31, 2022
Merged

Fix the CI after the Solidus v3.2 release#125
waiting-for-dev merged 5 commits into
solidusio:masterfrom
nebulab:elia+marc/fix-for-latest-solidus

Conversation

@elia

@elia elia commented Aug 30, 2022

Copy link
Copy Markdown
Member

No description provided.

@elia
elia force-pushed the elia+marc/fix-for-latest-solidus branch from ab6db88 to 2fd1c67 Compare August 30, 2022 11:19
It became an external gem in recent Ruby versions.

Co-Authored-By: Marc Busqué <marc@lamarciana.com>
@elia
elia force-pushed the elia+marc/fix-for-latest-solidus branch from 2fd1c67 to 8feca5d Compare August 30, 2022 11:20
elia and others added 2 commits August 30, 2022 13:21
Co-Authored-By: Marc Busqué <marc@lamarciana.com>
Co-Authored-By: Marc Busqué <marc@lamarciana.com>
@elia
elia force-pushed the elia+marc/fix-for-latest-solidus branch from 8feca5d to 84e84cc Compare August 30, 2022 11:21
We're only using chrome and skipping the firefox installation saves
time.
@elia
elia force-pushed the elia+marc/fix-for-latest-solidus branch from f59dadd to 0625e3a Compare August 30, 2022 14:03
@codecov-commenter

codecov-commenter commented Aug 30, 2022

Copy link
Copy Markdown

Codecov Report

Merging #125 (f85251a) into master (a83d320) will not change coverage.
The diff coverage is 20.00%.

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files          15       15           
  Lines         353      353           
=======================================
  Hits          335      335           
  Misses         18       18           
Impacted Files Coverage Δ
...llers/solidus_stripe/payment_request_controller.rb 73.91% <0.00%> (ø)
lib/solidus_stripe/configuration.rb 75.00% <ø> (ø)
...p/controllers/solidus_stripe/intents_controller.rb 95.83% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia
elia marked this pull request as ready for review August 30, 2022 15:48

@waiting-for-dev waiting-for-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👏

@waiting-for-dev
waiting-for-dev merged commit 5200a1b into solidusio:master Aug 31, 2022
@waiting-for-dev
waiting-for-dev deleted the elia+marc/fix-for-latest-solidus branch August 31, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants