Skip to content

Fix setup instructions for Rails 7#136

Merged
waiting-for-dev merged 1 commit into
solidusio:masterfrom
diegomichel:update-instructions-for-rails-7
Dec 2, 2022
Merged

Fix setup instructions for Rails 7#136
waiting-for-dev merged 1 commit into
solidusio:masterfrom
diegomichel:update-instructions-for-rails-7

Conversation

@diegomichel

Copy link
Copy Markdown
Contributor

Summary

Since Rails 7, it's no longer possible to reference a loadable constant on the initialize phase [1]. We need to wrap the setup within a to_prepare block, as it's already documented in our guides.

Credits to: @waiting-for-dev

Pretty much a copy of: solidusio/solidus_paypal_braintree#332

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

The following are not always needed (cross them out if they are not):

  • I have added automated tests to cover my changes.
  • I have attached screenshots to demo visual changes.
  • I have opened a PR to update the guides.
  • I have updated the README to account for my changes.

@waiting-for-dev waiting-for-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@waiting-for-dev
waiting-for-dev merged commit a68e0d9 into solidusio:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants