Skip to content

Fix adding a new customer card in admin#144

Merged
elia merged 1 commit into
solidusio:masterfrom
nebulab:fix-adding-card-in-admin
Dec 15, 2022
Merged

Fix adding a new customer card in admin#144
elia merged 1 commit into
solidusio:masterfrom
nebulab:fix-adding-card-in-admin

Conversation

@elia

@elia elia commented Dec 13, 2022

Copy link
Copy Markdown
Member

Summary

Adding a new card in the admin was updating the wrong fields. This adds support for creating a new card using v3_intents. It also support reusing an existing card.

Replaces #119

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

The following are not always needed (cross them out if they are not):

  • I have added automated tests to cover my changes.
  • I have attached screenshots to demo visual changes.
  • I have opened a PR to update the guides.
  • I have updated the README to account for my changes.

@elia elia self-assigned this Dec 13, 2022
@elia elia added this to the v4.4 milestone Dec 13, 2022
Adding a new card in the admin was updating the wrong fields.
This adds support for creating a new card using v3_intents.
It also support reusing an existing card.
@elia elia force-pushed the fix-adding-card-in-admin branch from 6a18219 to a5629da Compare December 14, 2022 12:13
@elia elia requested review from a team and spaghetticode December 14, 2022 16:30
@kennyadsl

Copy link
Copy Markdown
Member

Thanks @ikraamg and @elia!

@elia elia merged commit 084acdb into solidusio:master Dec 15, 2022
@elia elia deleted the fix-adding-card-in-admin branch December 15, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants