Fractional amount solidus-to-stripe conversion support class#155
Merged
Conversation
elia
force-pushed
the
elia/fractional-solidus-to-stripe-conversion
branch
from
69b1534 to
d4381dd
Compare
The Money gem used by Solidus and Stripe have different setups when it comes to handling amounts. Most of the time they're the same but there are special cases.
elia
force-pushed
the
elia/fractional-solidus-to-stripe-conversion
branch
from
d4381dd to
edca7bf
Compare
kennyadsl
approved these changes
Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Money gem used by Solidus and Stripe have different setups when it comes to handling fractional amounts. Most of the time they're the same but there are special cases in which the number of decimals included or the used multiplier is different between the two.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):- [ ] I have attached screenshots to demo visual changes. - [ ] I have opened a PR to update the [guides](https://github.com/solidusio/edgeguides). - [ ] I have updated the README to account for my changes.