bump min version of solidus_core dependency#176
Merged
elia merged 1 commit intoFeb 27, 2023
Conversation
soldius Stripe makes use of Omnes and the Spree::Bus, both introduced in solidus 3.2.0. With a version of solidus_core below 3.2, an app using this gem will not work
elia
approved these changes
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
soldius Stripe makes use of Omnes gem and the Spree::Bus, both introduced in solidus 3.2.0.
When trying to install solidus_stripe v5 With a version of solidus_core below 3.2, Omnes gem and
Spree::Busare not present but the current minimum version of solidus core for the solidus_stripe gem is 2.3.I bumped the minimal required version of solidus core.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: