Skip to content

Consolidate how Rails version is fetched for dummy-app and sandbox #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waiting-for-dev merged 1 commit into from
Mar 3, 2023
Merged

Consolidate how Rails version is fetched for dummy-app and sandbox #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bin/dummy-app
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ function unbundled {
test "$DB" = "sqlite" && export DB="sqlite3"

rm -rf ./dummy-app
rails ${RAILS_VERSION:+_${RAILS_VERSION}_} new dummy-app \
rails_version=`bundle exec ruby -e'require "rails"; puts Rails.version'`
rails _${rails_version}_ new dummy-app \

@elia elia Mar 2, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had issues with using this setup calling bundle exec, inside the script, thoughts on doing it the other way around and updating the sandbox instead?

Using the env var seems more adaptable to different situations and the Gemfile would be based on an environment variable anyway.

@waiting-for-dev waiting-for-dev Mar 3, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that in the script context, $RAILS_VERSION is expected to be an actual version, like 7.0 or 6.2. However, in other places of the Solidus ecosystem is expected to be a semver reference, like ~> 7.0. See docker config on main Solidus or the CircleCI orb as examples. (I use docker for development, and my docker-compose file had the env var; that was how it hit me 😅).

Do you recall which problem you found with bundle exec? At first sight, it looks like the safest way to get the actual version that we're using.

@elia elia Mar 3, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I think it was related to versions of bundler one nested into the other, but I don't have any reference, let's go with this code and if the problem comes up again we can switch to another solution 👍

@waiting-for-dev waiting-for-dev Mar 3, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, thanks, @elia!

--database=${DB:-sqlite3} \
--skip-git \
--skip-rc
Expand Down