Add SolidusStripe::Customer#216
Merged
Merged
Conversation
elia
force-pushed
the
elia+kennyadsl+marc/customer-refactor
branch
2 times, most recently
from
78f2185 to
95e6787
Compare
kennyadsl
approved these changes
Mar 15, 2023
loicginoux
reviewed
Mar 15, 2023
waiting-for-dev
approved these changes
Mar 15, 2023
elia
force-pushed
the
elia+kennyadsl+marc/customer-refactor
branch
3 times, most recently
from
f25f5f6 to
26f579e
Compare
…ed class - Use a polymorphic association to allow connecting it to either users or orders (for guest users) - Stop using metadata since we now store the id and we can rely on the database for fetching it - No need for fetching the customer form the API anywhere in the current implementation Co-Authored-By: Alberto Vena <kennyadsl@gmail.com> Co-Authored-By: Marc Busqué <marc@lamarciana.com>
elia
force-pushed
the
elia+kennyadsl+marc/customer-refactor
branch
from
26f579e to
9c940fe
Compare
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 94.92% 95.38% +0.46%
==========================================
Files 21 22 +1
Lines 414 412 -2
==========================================
Hits 393 393
+ Misses 21 19 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #163
Adds a
SolidusStripe::Customerclass that connects the user or the order (for guest users) to a stripe customer, ensuring it stays the same across order and intents generation.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: