Skip to content

Add a Payment Flow Strategy object#230

Closed
elia wants to merge 2 commits into
masterfrom
elia/strategy
Closed

Add a Payment Flow Strategy object#230
elia wants to merge 2 commits into
masterfrom
elia/strategy

Conversation

@elia

@elia elia commented Mar 17, 2023

Copy link
Copy Markdown
Member

Summary

Ref #210

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Mar 17, 2023
@elia
elia force-pushed the elia/strategy branch 2 times, most recently from 30f3eb3 to b12e704 Compare March 20, 2023 16:22
@codecov

codecov Bot commented Mar 20, 2023

Copy link
Copy Markdown

Codecov Report

Merging #230 (69cb741) into master (f827aec) will increase coverage by 1.63%.
The diff coverage is 97.59%.

❗ Current head 69cb741 differs from pull request most recent head d470375. Consider uploading reports for the commit d470375 to get more accurate results

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   96.39%   98.03%   +1.63%     
==========================================
  Files          23       24       +1     
  Lines         444      458      +14     
==========================================
+ Hits          428      449      +21     
+ Misses         16        9       -7     
Impacted Files Coverage Δ
...ll/templates/config/initializers/solidus_stripe.rb 100.00% <ø> (ø)
app/models/solidus_stripe/setup_intent.rb 95.65% <85.71%> (-4.35%) ⬇️
lib/solidus_stripe/payment_flow_strategy.rb 96.96% <96.96%> (ø)
...p/controllers/solidus_stripe/intents_controller.rb 100.00% <100.00%> (+15.09%) ⬆️
app/models/solidus_stripe/gateway.rb 96.55% <100.00%> (+0.06%) ⬆️
app/models/solidus_stripe/payment_intent.rb 100.00% <100.00%> (ø)
app/models/solidus_stripe/payment_method.rb 100.00% <100.00%> (ø)
config/routes.rb 100.00% <100.00%> (ø)
...lates/app/views/checkouts/payment/_stripe.html.erb 100.00% <100.00%> (+4.16%) ⬆️
lib/solidus_stripe/configuration.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia
elia force-pushed the elia/strategy branch 4 times, most recently from 0dbe563 to 69cb741 Compare March 22, 2023 14:51
@elia

elia commented Mar 28, 2023

Copy link
Copy Markdown
Member Author

Superseded by #249

@elia elia closed this Mar 28, 2023
@elia
elia deleted the elia/strategy branch March 28, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant