Guarantee payment is linked to payment intent when receiving webhooks#236
Merged
Merged
Conversation
We create and confirm the Stripe payment intent in two steps. That's to guarantee that we associate a Solidus payment on the creation, and we can fetch it after webhook events are published on confirmation. Closes #231
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
==========================================
+ Coverage 96.37% 96.39% +0.02%
==========================================
Files 23 23
Lines 441 444 +3
==========================================
+ Hits 425 428 +3
Misses 16 16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We create and confirm the Stripe payment intent in two steps. That's to
guarantee that we associate a Solidus payment on the creation, and we
can fetch it after webhook events are published on confirmation.
Closes #231
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: