-
-
Notifications
You must be signed in to change notification settings - Fork 66
Handle payment_intent.failed event #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
waiting-for-dev
merged 2 commits into
master
from
waiting-for-dev/handle_payment_intent_failed_event
Mar 23, 2023
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
spec/requests/solidus_stripe/webhooks_controller/payment_intent/payment_failed_spec.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| require "solidus_stripe_spec_helper" | ||
|
|
||
| RSpec.describe SolidusStripe::WebhooksController, type: %i[request webhook_request] do | ||
| describe "POST /create payment_intent.payment_failed" do | ||
| it "transitions the associated payment to failed" do | ||
| payment_method = create(:stripe_payment_method) | ||
| stripe_payment_intent = Stripe::PaymentIntent.construct_from(id: "pi_123") | ||
| payment = create(:payment, | ||
| payment_method: payment_method, | ||
| response_code: stripe_payment_intent.id, | ||
| state: "pending") | ||
| context = SolidusStripe::Webhook::EventWithContextFactory.from_object( | ||
| payment_method: payment_method, | ||
| object: stripe_payment_intent, | ||
| type: "payment_intent.payment_failed" | ||
| ) | ||
|
|
||
| expect do | ||
| webhook_request(context) | ||
| end.to change { payment.reload.state }.from("pending").to("failed") | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say that checking more generally if we can transition to failed is more generic and safe. You could be on a state (like checkout) where payment is not failed but doing the transition will raise an error. Same goes for the complete! event of the same file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestion, @loicginoux. If Solidus payment is in the
:checkoutstate, but we're already getting apayment_intent.payment_failedwebhook, that's probably an abnormal situation. I think it's better to be stricter so we can't detect any failure in our integration.