Handle payment_intent.canceled event#250
Merged
waiting-for-dev merged 1 commit intoMar 30, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 24 24
Lines 478 485 +7
=======================================
+ Hits 477 484 +7
Misses 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rainerdema
approved these changes
Mar 27, 2023
A `payment_intent.canceled` event is published [1] when canceling a payment intent from the Stripe dashboard. At that point, we need to update the associated Solidus payment to be voided. However, the webhook could also be received after voiding the payment from the Solidus admin interface, as it updates through Stripe's API. Therefore, we need to do nothing if the payment is already voided. Closes #181 [1] - https://stripe.com/docs/api/events/types#event_types-payment_intent.canceled
waiting-for-dev
force-pushed
the
waiting-for-dev/handle_payment_intent_canceled_event
branch
from
e5b1439 to
4079188
Compare
waiting-for-dev
deleted the
waiting-for-dev/handle_payment_intent_canceled_event
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
payment_intent.canceledevent is published when canceling a payment intent from the Stripe dashboard. At that point, we need to update the associated Solidus payment to be voided.However, the webhook could also be received after voiding the payment from the Solidus admin interface, as it updates through Stripe's API. Therefore, we need to do nothing if the payment is already voided.
Closes #181
[1] - https://stripe.com/docs/api/events/types#event_types-payment_intent.canceled
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: