Skip to content

Random fixes related to #249#256

Merged
elia merged 2 commits into
masterfrom
elia+rainer/random-fixes
Mar 29, 2023
Merged

Random fixes related to #249#256
elia merged 2 commits into
masterfrom
elia+rainer/random-fixes

Conversation

@elia

@elia elia commented Mar 29, 2023

Copy link
Copy Markdown
Member

Summary

Extracted from #249

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

elia and others added 2 commits March 29, 2023 12:42
Although no one should write a 10-line ternary, for simple cases is
more than ok.

Co-Authored-By: Rainer Dema <rainer.dema@gmail.com>
Co-Authored-By: Rainer Dema <rainer.dema@gmail.com>
@elia elia requested a review from kennyadsl March 29, 2023 10:43
@elia elia mentioned this pull request Mar 29, 2023
3 tasks
@codecov

codecov Bot commented Mar 29, 2023

Copy link
Copy Markdown

Codecov Report

Merging #256 (eec0adb) into master (bad6ed0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files          24       24           
  Lines         478      478           
=======================================
  Hits          477      477           
  Misses          1        1           
Impacted Files Coverage Δ
app/models/solidus_stripe/payment_intent.rb 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia merged commit a530db7 into master Mar 29, 2023
@elia elia deleted the elia+rainer/random-fixes branch March 29, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants