Remove support for Ruby v2.7#259
Merged
Merged
Conversation
elia
reviewed
Mar 29, 2023
elia
left a comment
elia
left a comment
Member
There was a problem hiding this comment.
I think we need to correct the ruby version for the linter https://github.com/solidusio/solidus_stripe/blob/waiting-for-dev/deprecate_ruby_v3/.circleci/config.yml#L86
waiting-for-dev
force-pushed
the
waiting-for-dev/deprecate_ruby_v3
branch
3 times, most recently
from
bab9496 to
3545184
Compare
Ruby v2.7 will reach EOL on 2023-03-31, so we'll be removing support on Solidus very soon.
waiting-for-dev
force-pushed
the
waiting-for-dev/deprecate_ruby_v3
branch
from
3545184 to
6ab215e
Compare
Contributor
Author
Good call! For now, I have parametrized the parameter on our end to avoid seeing failure in other extensions |
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 25 25
Lines 481 481
=======================================
Hits 480 480
Misses 1 1 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kennyadsl
approved these changes
Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ruby v2.7 will reach EOL on 2023-03-31, so we'll be removing support on Solidus very soon.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: