Add caching support to sandbox apps creation#272
Merged
Conversation
With a warm cache the sandbox app creation goes from ~130s to ~30s on my Apple M1. The optimization is used for the dummy-app creation as well.
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
==========================================
- Coverage 99.59% 99.56% -0.03%
==========================================
Files 27 26 -1
Lines 489 462 -27
==========================================
- Hits 487 460 -27
Misses 2 2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rainerdema
approved these changes
Apr 4, 2023
rainerdema
left a comment
rainerdema
left a comment
Contributor
There was a problem hiding this comment.
With a warm cache the sandbox app creation goes from ~130s to ~30s on my Apple M1.
✨
Amazing improvement @elia! Thanks! 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With a warm cache the sandbox app creation goes from ~130s to ~30s on my Apple M1.
The optimization is used for the dummy-app creation as well.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: