Protect against concurrent duplicated webhooks#285
Closed
waiting-for-dev wants to merge 1 commit into
Closed
Conversation
By acquiring an update lock on the payment, we can ensure that only one concurrent excecution of the webhook handler will manipulate it. That will avoid duplicated log entries and obscure exceptions. Closes #188
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 27 27
Lines 489 489
=======================================
Hits 487 487
Misses 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rainerdema
reviewed
Apr 17, 2023
Contributor
Author
|
Sorry, replaced by #286 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
By acquiring an update lock on the payment, we can ensure that only one concurrent excecution of the webhook handler will manipulate it. That will avoid duplicated log entries and obscure exceptions.
Closes #188
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: