Skip to content

Add more versions of ruby and more databases to the CI matrix#303

Merged
elia merged 2 commits into
mainfrom
elia/expand-the-ci-matrix
May 2, 2023
Merged

Add more versions of ruby and more databases to the CI matrix#303
elia merged 2 commits into
mainfrom
elia/expand-the-ci-matrix

Conversation

@elia

@elia elia commented Apr 27, 2023

Copy link
Copy Markdown
Member

Summary

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia added this to the v5 milestone Apr 27, 2023
@elia elia self-assigned this Apr 27, 2023
@elia elia force-pushed the elia/expand-the-ci-matrix branch 4 times, most recently from 2da8e9b to ac58c0b Compare April 28, 2023 11:54
@elia elia force-pushed the elia/expand-the-ci-matrix branch from a1ca353 to feb861d Compare April 28, 2023 19:50
@elia

elia commented Apr 28, 2023

Copy link
Copy Markdown
Member Author

Had to change all calls to #references and add the foreign key separately, as for each of the this was shown with MySQL:

== 20230428115654 CreateSolidusStripePaymentIntents: migrating ================
-- create_table(:solidus_stripe_payment_intents)
rails aborted!
StandardError: An error has occurred, all later migrations canceled:

Column `order_id` on table `solidus_stripe_payment_intents` does not match column `id` on `spree_orders`, which has type `int(11)`. To resolve this issue, change the type of the `order_id` column on `solidus_stripe_payment_intents` to be :integer. (For example `t.integer :order_id`).
Original message: Mysql2::Error: Cannot add foreign key constraint
/home/circleci/project/dummy-app/db/migrate/20230428115654_create_solidus_stripe_payment_intents.solidus_stripe.rb:4:in `change'

Caused by:
ActiveRecord::MismatchedForeignKey: Column `order_id` on table `solidus_stripe_payment_intents` does not match column `id` on `spree_orders`, which has type `int(11)`. To resolve this issue, change the type of the `order_id` column on `solidus_stripe_payment_intents` to be :integer. (For example `t.integer :order_id`).
Original message: Mysql2::Error: Cannot add foreign key constraint
/home/circleci/project/dummy-app/db/migrate/20230428115654_create_solidus_stripe_payment_intents.solidus_stripe.rb:4:in `change'

Caused by:
Mysql2::Error: Cannot add foreign key constraint
/home/circleci/project/dummy-app/db/migrate/20230428115654_create_solidus_stripe_payment_intents.solidus_stripe.rb:4:in `change'
Tasks: TOP => db:migrate
(See full trace by running task with --trace)

MySQL had an issue with doing the same with `t.references`.
@elia elia force-pushed the elia/expand-the-ci-matrix branch from feb861d to c8528ba Compare April 28, 2023 20:01
@codecov

codecov Bot commented Apr 28, 2023

Copy link
Copy Markdown

Codecov Report

Merging #303 (c8528ba) into main (100b9c3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #303   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files          31       31           
  Lines         563      563           
=======================================
  Hits          561      561           
  Misses          2        2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia marked this pull request as ready for review April 29, 2023 22:24
@elia elia merged commit 5d70ca3 into main May 2, 2023
@elia elia deleted the elia/expand-the-ci-matrix branch May 2, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants