Skip to content

Ensure reloading the confirmation page doesn't break the checkout#317

Merged
elia merged 1 commit into
mainfrom
elia/confirm-page-refresh
Nov 29, 2023
Merged

Ensure reloading the confirmation page doesn't break the checkout#317
elia merged 1 commit into
mainfrom
elia/confirm-page-refresh

Conversation

@elia

@elia elia commented Nov 28, 2023

Copy link
Copy Markdown
Member

Summary

Looks like we missed this pattern in which a payment intent state was advanced while rendering the confirmation page.
Adding support for this state ensures we don't get a 500 by simply refreshing the confirmation page.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Nov 28, 2023
@elia
elia force-pushed the elia/confirm-page-refresh branch from 39f6a68 to 04da679 Compare November 28, 2023 16:20
@codecov

codecov Bot commented Nov 29, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6390ee) 99.64% compared to head (04da679) 99.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #317   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files          31       31           
  Lines         563      564    +1     
=======================================
+ Hits          561      562    +1     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elia
elia marked this pull request as ready for review November 29, 2023 09:39
@elia
elia merged commit 6aba1a9 into main Nov 29, 2023
@elia
elia deleted the elia/confirm-page-refresh branch November 29, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants