Improve the way Stripe Elements validation errors are displayed#40
Merged
aldesantis merged 1 commit intoMar 26, 2020
Conversation
aldesantis
approved these changes
Mar 26, 2020
Member
|
Thanks @stuffmatic, looks great. Also wanted to personally thank you on behalf of the core team for the amazing work you've been doing lately with your issues and PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Stripe Element validation errors are only shown for the card number field. This pull request aims to improve the error display logic to handle errors from all fields. Here's what it looks like:
The code is adapted from this source file in the official Stripe Elements examples repo (live official examples are here).