Remove Stripe::CardError leftover#58
Merged
aldesantis merged 1 commit intoMay 16, 2020
Merged
Conversation
The error `Stripe::CardError` is defined inside the official Stripe gem, which was used in the beginnig for developing a early version of the payment intents flow. We later switched to Active Merchant in order to reduce the number of dependencies, as the latter was already in use on this extension and since version 1.101 is capable of handing Stripe Payment Intents as well. The begin/rescue block was completely removed since there's no known error that can be generated during the creation of the Payment Intent that makes sense to rescue. This is also due to the fact that Active Merchant already tries to manage many possible errors at a lower level. The fact that this leftover remained unnoticed for so long is proof that no error is usually generated in that part of the code.
aldesantis
approved these changes
May 16, 2020
aldesantis
left a comment
aldesantis
left a comment
Member
There was a problem hiding this comment.
Thanks for the detailed explanation and the fix @spaghetticode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55
The error
Stripe::CardErroris defined inside the official Stripe gem, which was used in the beginnig for developing a early version of the payment intents flow. We later switched to Active Merchant in order to reduce the number of dependencies, as the latter was already in use on this extension and since version 1.101 is capable of handing Stripe Payment Intents as well.The begin/rescue block was completely removed since there's no known error that can be generated during the creation of the Payment Intent that makes sense to rescue. This is also due to the fact that Active Merchant already tries to manage many possible errors at a lower level.
The fact that this leftover remained unnoticed for so long is proof that no error is usually generated in that part of the code, @rainerdema was able to exercise the
rescueblock while writing tests, wherecurrent_orderwas left tonilby mistake.