Try to find address state also by name#65
Merged
spaghetticode merged 2 commits intoJun 26, 2020
Conversation
This new iframe has been added inside the stripe 3d secure authorization modal. We need to take it into account or specs will fail.
spaghetticode
force-pushed
the
spaghetticode/region-for-state
branch
from
June 12, 2020 09:19
3cca5e2 to
ded3ca8
Compare
There have been reports about `AddressFromParamsService` not being able to find the address state by using the `abbr` field. In those instances the provided `region` parameter matched the state name. Also, small improvements in specs ensure tests are more accurate.
spaghetticode
force-pushed
the
spaghetticode/region-for-state
branch
from
June 12, 2020 10:26
52d11d4 to
f361f18
Compare
kennyadsl
approved these changes
Jun 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been reports about
AddressFromParamsServicenot being able to find the address state by using theabbrfield. In those instances the providedregionparameter matched the state name.Also, small improvements in specs ensure tests are more accurate.