Fix Copyright in README#73
Merged
Merged
Conversation
aldesantis
approved these changes
Jul 9, 2020
aldesantis
left a comment
aldesantis
left a comment
Member
There was a problem hiding this comment.
No idea how that happened 🤦
elia
requested changes
Jul 14, 2020
elia
left a comment
elia
left a comment
Member
There was a problem hiding this comment.
If we want to change the copyright we should at least also preserve the original, being NewBSD I think we're allowed to do that, but not to remove the original license (as proposed by @ccarruitero in #59).
For the record, the history of this change is the following:
- an update done with solidus_dev_support brought in an additional
LICENSEfile in addition to the already existingLICENSE.md - the older file was subsequently removed by yours truly restoring the original copyright
spaghetticode
force-pushed
the
kennyadsl/copy-update
branch
from
September 25, 2020 11:46
5ee77bf to
2f613e3
Compare
Member
|
Fixes #59 |
spaghetticode
force-pushed
the
kennyadsl/copy-update
branch
from
September 25, 2020 11:54
2f613e3 to
db09871
Compare
spaghetticode
force-pushed
the
kennyadsl/copy-update
branch
from
September 25, 2020 12:01
db09871 to
9c6cc19
Compare
Member
Author
|
I opened the PR, so I can't approve, but I approve! |
Member
|
Luckily for us (I can't approve it either, as I edited the PR) @aldesantis had already approved it 🎉 🤪 |
Member
|
CI failure is not related to changes, so merging it anyway. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔