Add missing 'var'#85
Merged
Merged
Conversation
spaghetticode
approved these changes
Oct 2, 2020
spaghetticode
left a comment
spaghetticode
left a comment
Member
There was a problem hiding this comment.
@willread thanks for the fix 👍
Member
|
CI failure is unrelated to the changes, so I'm merging anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
onShippingAddressChangefunction is missing avarkeyword which results in an implicit global and causes a strict mode violation.There doesn't appear to be any code depending on this behaviour so I assume this is a simple fix.