Fix 3DS iframe selection#86
Merged
aldesantis merged 3 commits intoOct 2, 2020
Merged
Conversation
Stripe is now using random names for their iframe containers, so we need to resort to some other strategy for finding the iframe that contains the one named `__stripeJSChallengeFrame`. Currently, one reliable way to find this iframe is by using a non-changing part of its `src` attribute.
We recently switched to Selenium so we need to add this command whenever an alert message is opened in the browser.
Member
|
@spaghetticode looks like the CI is still failing, but I'm not sure if the problem is related. |
In Solidus we changed the way we void payments. When the payment has zero amount we don't try to void anymore.
Member
Author
|
@aldesantis yes it is, that's because of some recent changes in Solidus... which I authored myself 🤪 |
aldesantis
approved these changes
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix should bring the gem CI back to green status.
Stripe is now using random names for their iframe containers, so we need to resort to some other strategy for finding the iframe that contains the one named
__stripeJSChallengeFrame.Currently, one reliable way to find this iframe is by using a non-changing part of its
srcattribute.