Add a method to check if combined address name is being used #58
Merged
Conversation
To be able to have a working console. For some reason it's not loading Rails correctly, some pieces are missing.
6 tasks
kennyadsl
changed the title
This helper method checks if a store is using the old or new way of setting address' name. It will act as a migration support to create conditional code to make extensions work compatible with both versions. We can remove this method when the last 2.x version will reach EOL.
kennyadsl
force-pushed
the
kennyadsl/check-address
branch
from
d884114 to
4f3ccab
Compare
aldesantis
approved these changes
Jan 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helper method checks if a store is using the old or new way of setting the address' name.
It will act as a migration support to create conditional code to make extensions work compatible with both versions.
We can remove this method when the last 2.x version will reach EOL.
cc @filippoliverani