Update SetClusterName and GetClusterName to use generateName instead of annotations #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcguire98
changed the title
|
Issues linked to changelog: |
marcogschmidt
previously approved these changes
Apr 7, 2025
marcogschmidt
approved these changes
Apr 7, 2025
jehawley
approved these changes
Apr 8, 2025
jmcguire98
added a commit
that referenced
this pull request
Apr 22, 2025
…of annotations (#593) * add backwards compatibility in skv2 * add changelog * update skv2 to not fallback to annotations * try backwards compatibility fallback on gets, but not sets * clean up skv2 unit tests * fix changelog * fix issuelink * address nit
soloio-bulldozer bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
….x (#596) * Update SetClusterName and GetClusterName to use generateName instead of annotations (#593) * add backwards compatibility in skv2 * add changelog * update skv2 to not fallback to annotations * try backwards compatibility fallback on gets, but not sets * clean up skv2 unit tests * fix changelog * fix issuelink * address nit * move changelog * move changelog into 0.36.7 since it was not cut yet * Revert "move changelog into 0.36.7 since it was not cut yet" This reverts commit 341c6c2. * Minify Helm chart values JSON schema (#595) * Don't prettify chart values JSON schema * Changelog * Make linter happy Remove unused functions Add default switch clause * Move changelog * Codegen * Update unit tests assertions * Tests: use `json.Compact` to minify * Un-focus test * Remove unused function # Conflicts: # codegen/test/chart/values.schema.json * move minify helm changelog * merge changelog files * fix codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates SetClusterName and GetClusterName to use the
generateNamefield per https://github.com/solo-io/gloo-mesh-enterprise/issues/16342, with GetClusterName maintaining the ability to fallback to annotations or deprecated field names for tooling and testing purposes.Context
see https://github.com/solo-io/gloo-mesh-enterprise/issues/16342 or https://solo-io-corp.slack.com/archives/C08BL9Z080H for broader discussion