Backport cluster data race fixes to 0.42.1 #594
Merged
+98
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
jehawley
approved these changes
Apr 8, 2025
birkland
approved these changes
Apr 8, 2025
jmcguire98
force-pushed
the
jmcguire/backport-cluster-data-race-fixes
branch
from
6a13a06 to
0c1eef5
Compare
soloio-bulldozer
bot
deleted the
jmcguire/backport-cluster-data-race-fixes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates SetClusterName and GetClusterName to use the generateName field per https://github.com/solo-io/gloo-mesh-enterprise/issues/16342, with GetClusterName maintaining the ability to fallback to annotations or deprecated field names for tooling and testing purposes.
Context
see https://github.com/solo-io/gloo-mesh-enterprise/issues/16342 or https://solo-io-corp.slack.com/archives/C08BL9Z080H for broader discussion