Fix viewer crash with linear_wave app loaded #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linear_wave app uses PySide6 for matplotlib to create a new window, and it seems to conflict with the shutdown sequence of python interpreter. Change the interpreter shotdown order to fix it. In addition, improve the interpreter wrapping API. Do not initialize the interpreter in the constructor of the class Interpreter.
yungyuc
commented
Jul 16, 2022
|
|
||
| int main(int argc, char ** argv) | ||
| { | ||
| // Set up Python interpreter. |
Member
Author
There was a problem hiding this comment.
Initialize the interpreter in the beginning of program.
| Interpreter & Interpreter::initialize() | ||
| { | ||
| setup_path(); | ||
| if (nullptr == m_interpreter) |
Member
Author
There was a problem hiding this comment.
Do not re-enter the initialization.
| Interpreter & Interpreter::finalize() | ||
| { | ||
| // NOLINTNEXTLINE(readability-delete-null-pointer) | ||
| if (nullptr != m_interpreter) |
Member
Author
There was a problem hiding this comment.
Avoid null dereferencing.
|
|
||
| RApplication::~RApplication() | ||
| { | ||
| // Shuts down the interpreter when the application stops. |
Member
Author
There was a problem hiding this comment.
Shuts down interpreter when the application is finishing.
| from modmesh.app import linear_wave as app | ||
| svr = app.run_linear() | ||
| # Need to hold the win object to keep PySide alive. |
Member
Author
There was a problem hiding this comment.
Manage the lifecycle in the application region.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linear_wave app uses PySide6 for matplotlib to create a new window, and it seems to conflict with the shutdown sequence of python interpreter.
Change the interpreter shotdown order to fix it.
In addition, improve the interpreter wrapping API. Do not initialize the interpreter in the constructor of the class Interpreter.
ref #100