Create a new Python module modmesh.apputil to manage app environment
#105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the primitive C++ code for running the viewer pytext code for an application to the new module `modmesh.apputil`. A new class `AppEnvironment` is defined to hold the symbols for the application, so that the symbols will not scatter in the interpreter `__main__`. Each run of the applications will create a new app environment, which is collected in the list `modmesh.apputil.environ`. Also in this commit: Rename `FIXME` to `TODO`.
* Run all supported platforms (ubuntu 20.04 and 22.04, macos 11 and 12) with only Release flavor and without clang-tidy (which takes a long of runtime). * Add a new CI workflow `modmesh_lint` to only run clang-tidy and flake8 (linter) with Debug flavor and the latest platform (ubuntu 22.04 and macos 12). * Fix the directory name of `modmesh_format`. * Update `modmesh_install` to use the latest platform (ubuntu 22.04 and macos 12).
yungyuc
commented
Jul 17, 2022
| path: | ||
| - 'include' | ||
| - 'src' | ||
| - 'cpp' |
Member
Author
There was a problem hiding this comment.
We ran the workflow without checking anything for a while :)
| strategy: | ||
| matrix: | ||
| os: [ubuntu-20.04, macos-11] | ||
| os: [ubuntu-22.04, macos-12] |
| - name: dependency (ubuntu) | ||
| if: ${{ startsWith(matrix.os, 'ubuntu') }} | ||
| run: | | ||
| VERSION_ID=$(bash -c 'source /etc/os-release ; echo $VERSION_ID') |
Member
Author
There was a problem hiding this comment.
Align from other workflows.
|
|
||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-22.04, macos-12] |
Member
Author
There was a problem hiding this comment.
Run clang-tidy and flake8 only with the latest platforms and debug flavor.
| run: | | ||
| make buildext \ | ||
| VERBOSE=1 BUILD_QT=OFF USE_CLANG_TIDY=ON \ | ||
| VERBOSE=1 BUILD_QT=OFF USE_CLANG_TIDY=OFF \ |
Member
Author
There was a problem hiding this comment.
Turn off clang-tidy for pytest workflow.
| make pytest \ | ||
| VERBOSE=1 BUILD_QT=OFF USE_CLANG_TIDY=ON \ | ||
| CMAKE_BUILD_TYPE=${{ matrix.cmake_build_type }} \ | ||
| CMAKE_ARGS="-DPYTHON_EXECUTABLE=$(which python3)" |
Member
Author
There was a problem hiding this comment.
Turn off flake8 for pytest workflow.
| }; /* end struct StaticMeshConstant */ | ||
|
|
||
| // FIXME: StaticMeshBC may use polymorphism. | ||
| // TODO: StaticMeshBC may use polymorphism. |
Member
Author
There was a problem hiding this comment.
FIXME should be a reminder before checking in. TODO may live longer.
|
|
||
| #include <modmesh/spacetime/base_spacetime.hpp> | ||
| #include "modmesh/math.hpp" | ||
| #include <modmesh/math.hpp> |
| /* TODO: parse arguments */ | ||
|
|
||
| // Set up menu. | ||
| /* TODO: Menu setup may be moved to Python */ |
Member
Author
There was a problem hiding this comment.
@yanagiragi Moving this to Python can make it easier to maintain.
| The local namespace of the application. | ||
| """ | ||
| def __init__(self): | ||
| self.locals = { |
Member
Author
There was a problem hiding this comment.
Give the environment a local namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the primitive C++ code for running the viewer pytext code for an application to the new module
modmesh.apputil. A new classAppEnvironmentis defined to hold the symbols for the application, so that the symbols will not scatter in the interpreter__main__.Each run of the applications will create a new app environment, which is collected in the list
modmesh.apputil.environ.Also in this commit: Rename
FIXMEtoTODO.ref #100