Refactor spacetime and view #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge all code in spacetime to only core.[hc]pp and io.[hc]pp.
Move the ::spacetime namespace to ::modmesh::spacetime.
yungyuc
added
refactor
Member
Author
|
Again, the diff is large and I think it does not make sense for anyone else to review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the code of spacetime to only a couple of files, and from the
spacetimenamespace tomodmesh::spacetimenamespace.Move the Python source files of view to be with the rest view source files, because the whole directory of
view/depends on Python.