feat: Use FPSCamera to improve control #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungyuc
requested changes
Jul 30, 2022
Member
yungyuc
left a comment
yungyuc
left a comment
There was a problem hiding this comment.
Both QOrbitCameraControl and QFirstPersonCameraControl look useful. Can we keep both and switch using a menu entry?
Contributor
Author
|
Sure. Which one should be the default camera? |
Member
Either is OK. It will be configurable once we figure out a good way to implement #84 . |
Contributor
Author
|
@yungyuc I've upload the changes. |
yungyuc
approved these changes
Aug 14, 2022
| viewer->scene()->controller()->setCamera(viewer->camera()); | ||
| }); | ||
|
|
||
| auto * cameraGroup = new QActionGroup(this); |
Member
There was a problem hiding this comment.
We have been mixing camelCase and snake_name for local variables. You didn't start it. But we should start to think about how to end it. It will probably take more time for us to accumulate code before coming up with a good guideline.
|
|
||
| cameraMenu->addAction(use_orbit_camera); | ||
| cameraMenu->addAction(use_fps_camera); | ||
| menuBar->addMenu(cameraMenu); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#70
I replace to original orbital camera to first person camera to improve camera controls, In my opinion the controls are more straight forward.
Currently the new camera contain some cons:
However, auto focus to the whole scene is the killer feature. I highly recommend to give it a try.
P.S. The supported controls is documented in here.