Skip to content

Conversation

@minchuncho
Copy link
Contributor

  1. Specify the version of mac os: 12
  2. Align the commands with the ones in
    brew install python3 llvm

@minchuncho
Copy link
Contributor Author

minchuncho commented Aug 19, 2022

My old version of CI is as follows:

brew install wget make cmake libccd gcc python3 qt6
pip3 install -U numpy pytest flake8

Curious, I didn't write the following line but the old version still worked.

pip3 install -U setuptools

I found that setuptools is a Python package development process library, i.e., enhanced disutils, while disutils is a Python standard library.
May I reach to this conclusion that if setuptools is not installed, then disutils is chosen by default so the old version still ran well?

Copy link
Member

@yungyuc yungyuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the regression to os version alias.

@yungyuc
Copy link
Member

yungyuc commented Aug 19, 2022

Curious, I didn't write the following line but the old version still worked.

pip3 install -U setuptools

I found that setuptools is a Python package development process library, i.e., enhanced disutils, while disutils is a Python standard library. May I reach to this conclusion that if setuptools is not installed, then disutils is chosen by default so the old version still ran well?

That is a reasonable guess, I think. I do not know the answer either. It probably does not matter ATM, but could be interesting to learn.

Replace `macos-latest` with `macos-12`.
@minchuncho minchuncho force-pushed the 111-macos-viewer-ci branch from 0a84f07 to 304a5cb Compare August 19, 2022 07:25
@yungyuc yungyuc merged commit 8751b6f into solvcon:master Aug 19, 2022
@yungyuc
Copy link
Member

yungyuc commented Aug 19, 2022

Thanks @minchuncho . This addressed #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants